[webkit-reviews] review denied: [Bug 48172] check-webkit-style script should be changed for WebKit2 : [Attachment 71623] Filtering files which have followed GTK naming convention

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 23 07:14:58 PDT 2010


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Amruth Raj
<amruthraj at motorola.com>'s request for review:
Bug 48172: check-webkit-style script should be changed for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48172

Attachment 71623: Filtering files which have followed GTK naming convention
https://bugs.webkit.org/attachment.cgi?id=71623&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71623&action=review

r- to fix the ChangeLog.  Otherwise this looks fine.

> WebKitTools/ChangeLog:1
> +2010-10-22  Amruth Raj/Ravi Kasibhatla 
<amruthraj at motorola.com/ravi.kasibhatla at motorola.com>

Please reformat authors and email addresses:

2010-10-22  Amruth Raj	<amruthraj at motorola.com> and Ravi Kasibhatla 
<ravi.kasibhatla at motorola.com>

> WebKitTools/ChangeLog:7
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Adding the WebKit2/UIProcess/gtk as a exception for style checking.
> +	   The folder has two files WebViewInternal.h and WebViewInternal.cpp
> +	   which follow GTK naming convention.

Please add the bug title and a link to the bug in the ChangeLog.


More information about the webkit-reviews mailing list