[webkit-reviews] review denied: [Bug 48183] Add Gradient::hasAlpha : [Attachment 71637] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 23 07:00:36 PDT 2010
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 48183: Add Gradient::hasAlpha
https://bugs.webkit.org/show_bug.cgi?id=48183
Attachment 71637: Patch
https://bugs.webkit.org/attachment.cgi?id=71637&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71637&action=review
r- due to the for() loop style issue
> WebCore/platform/graphics/Gradient.cpp:203
> + for (size_t i = 0; i < m_stops.size(); i++)
> + if (m_stops[i].alpha < 1)
> + return true;
The for loop must have curly braces around it because it's body is more than
two lines.
More information about the webkit-reviews
mailing list