[webkit-reviews] review requested: [Bug 28272] WINCE PORT: graphics files only for WINCE : [Attachment 71636] 1) SharedBitmap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 23 05:43:26 PDT 2010


Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 28272: WINCE PORT: graphics files only for WINCE
https://bugs.webkit.org/show_bug.cgi?id=28272

Attachment 71636: 1) SharedBitmap
https://bugs.webkit.org/attachment.cgi?id=71636&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
There are some parts of uncool code in the patch:
E.g: HDC SharedBitmap::DCProvider::getDC(SharedBitmap* bmp, unsigned* key1,
unsigned* key2)

I'd like to commit the patch as it is at the moment, because many code in the
other WinCE files require this constructs.
E.g: ScopeDCProvider in GraphicsContextWinCE

If it's ok, I want to clean this up in further patches, so we can see the
codechanges of the already comitted code in context with the other changes.


More information about the webkit-reviews mailing list