[webkit-reviews] review denied: [Bug 44528] Improve FEGaussianBlur algorithm to access image buffer memory directly : [Attachment 65698] Proposed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 44528: Improve FEGaussianBlur algorithm to access image buffer memory
directly
https://bugs.webkit.org/show_bug.cgi?id=44528

Attachment 65698: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=65698&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=65698&action=review

Have you tried to use the original code, but take the WTF::ByteArray instead of
the CanvasPixelArray? I'm interested in how much perf win this could bring.
Surely not as much as your code, but still. Also it is not needed here to mark
the surface as dirty. This is only necessary, if you want to access the context
after pixel manipulations. That isn't the case here or on any other filter
effect result.
You also ignored, that some platforms may use unpremultiplied colors. Would be
great if we can find a way to manage pixel access with premultiplied and
unpremultiplied colors, that would be a win for the other filter effects as
well.

I know that you were working on that to make CSS shadows faster on Cairo. But
it would still be useful for SVG filter effects (that are supported by
WebKitGtk as well).

> WebCore/platform/graphics/wx/ImageBufferWx.cpp:72
> +	notImplemented();

indention wrong.