[webkit-reviews] review denied: [Bug 48035] WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures : [Attachment 71470] Review for patch to WebWindowFeatures.h that fixes a constructor call to keep WebWindowFeatures always in a valid state.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 23 00:02:38 PDT 2010


Csaba Osztrogonac <ossy at webkit.org> has denied usaini <usaini08 at gmail.com>'s
request for review:
Bug 48035: WebWindowFeatures has a faulty constructor for
WebCore::WindowFeatures
https://bugs.webkit.org/show_bug.cgi?id=48035

Attachment 71470: Review for patch to WebWindowFeatures.h that fixes a
constructor call to keep WebWindowFeatures always in a valid state.
https://bugs.webkit.org/attachment.cgi?id=71470&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
Please add a changelog entry with WebKitTools/Scripts/prepare-changelog,
and then add a comment to the changelog why this change is needed.

Additionally run svn-create-patch from the root of the WebKit directory
and not from WebKit/chromium. It will make EWS bots happier. :)


More information about the webkit-reviews mailing list