[webkit-reviews] review granted: [Bug 48165] commit-queue should not pass --quiet to subcommands now that the parent command does the reporting : [Attachment 71614] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 22 17:16:23 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 48165: commit-queue should not pass --quiet to subcommands now that the
parent command does the reporting
https://bugs.webkit.org/show_bug.cgi?id=48165
Attachment 71614: Patch
https://bugs.webkit.org/attachment.cgi?id=71614&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71614&action=review
Ok. Are we going to run out of disk space? :)
> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:144
> + # Unclear if this should pass --quiet or not. If --parent-command
always does the reporting, than it should.
than => then
More information about the webkit-reviews
mailing list