[webkit-reviews] review granted: [Bug 48155] Fix assert when a NetscapePluginModule loses its last NetscapePlugin. : [Attachment 71596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 22 14:47:52 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 48155: Fix assert when a NetscapePluginModule loses its last
NetscapePlugin.
https://bugs.webkit.org/show_bug.cgi?id=48155

Attachment 71596: Patch
https://bugs.webkit.org/attachment.cgi?id=71596&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71596&action=review

> WebKit2/ChangeLog:16
> +	   Set m_sInitialized to false.

Typo: m_sInitialized.

Can you make a test?

It would be nice to say what assertion was failing and when. Then we'll have a
hope of reproducing this in the future if we need to.


More information about the webkit-reviews mailing list