[webkit-reviews] review granted: [Bug 48153] Crash in Connection::isValid when called in response to VisitedLinksProvider::pendingVisitedLinksTimerFired after WebProcessPRoxy::didClose was already called : [Attachment 71594] Add WebContext::proccessDidClose and stop the visited links timer there

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 48153: Crash in Connection::isValid when called in response to
VisitedLinksProvider::pendingVisitedLinksTimerFired after
WebProcessPRoxy::didClose was already called
https://bugs.webkit.org/show_bug.cgi?id=48153

Attachment 71594: Add WebContext::proccessDidClose and stop the visited links
timer there
https://bugs.webkit.org/attachment.cgi?id=71594&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71594&action=review

Looks great otherwise, r=me!

> WebKit2/UIProcess/WebProcessProxy.cpp:420
> +    m_context->processDidClose(this);

You should call processDidClose before the call to
WebProcessManager::processDidClose because calling it might delete the
WebProcessProxy object.