[webkit-reviews] review granted: [Bug 48149] Update block direction overflow for lines to be writing-mode-aware. : [Attachment 71589] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 48149: Update block direction overflow for lines to be writing-mode-aware.
https://bugs.webkit.org/show_bug.cgi?id=48149

Attachment 71589: Patch
https://bugs.webkit.org/attachment.cgi?id=71589&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71589&action=review

> WebCore/rendering/style/RenderStyle.h:644
> +    void getTextShadowBlockDirectionExtent(int& logicalTop, int &
logicalBottom) { getShadowBlockDirectionExtent(textShadow(), logicalTop,
logicalBottom); }

Weird spacing around the &.

> WebCore/rendering/style/RenderStyle.h:664
> +    void getBoxShadowBlockDirectionExtent(int& logicalTop, int &
logicalBottom) { getShadowBlockDirectionExtent(boxShadow(), logicalTop,
logicalBottom); }

Here too.