[webkit-reviews] review granted: [Bug 48140] WebKit2 needs to pass the current event modifier flags when requesting a new window : [Attachment 71578] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 48140: WebKit2 needs to pass the current event modifier flags when
requesting a new window
https://bugs.webkit.org/show_bug.cgi?id=48140

Attachment 71578: Patch
https://bugs.webkit.org/attachment.cgi?id=71578&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71578&action=review

> WebCore/page/ContextMenuController.cpp:144
> +	   if (Page* newPage = oldPage->chrome()->createWindow(frame,
FrameLoadRequest(ResourceRequest(urlToLoad,
frame->loader()->outgoingReferrer())), features, action))

You can just pass NavigationAction as a temporary here.