[webkit-reviews] review denied: [Bug 47089] Language tag in speech for HTML input elements : [Attachment 71569] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 47089: Language tag in speech for HTML input elements
https://bugs.webkit.org/show_bug.cgi?id=47089

Attachment 71569: Patch
https://bugs.webkit.org/attachment.cgi?id=71569&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71569&action=review

> WebCore/ChangeLog:18
> +	   Fixed a problem in dom/Element.cpp that caused some layout tests to
fail.

No need to mention that - this doesn't fix any problems in ToT.

> WebCore/ChangeLog:22
> +	   (WebCore::Element::computeInheritedLanguage): includes a brief
character
> +	     validation for the BCP 47 language tag.

Please file a separate bug for this, and provide a patch that tests this change
with default WebKit build options (i.e. outside of speech recognition context).
r- for the need to split DOM changes out.