[webkit-reviews] review granted: [Bug 48046] WebKit shouldn't load a plug-in based on file extension if a MIME type is specified. : [Attachment 71514] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 22 10:29:18 PDT 2010


Eric Carlson <eric.carlson at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 48046: WebKit shouldn't load a plug-in based on file extension if a MIME
type is specified.
https://bugs.webkit.org/show_bug.cgi?id=48046

Attachment 71514: Patch
https://bugs.webkit.org/attachment.cgi?id=71514&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
Much simpler test, nice! 

One very minor nit that you might want to change: you don't need to call
finishTest from logFailure, just get rid of the "else" after calling
testCallback.

r=me


More information about the webkit-reviews mailing list