[webkit-reviews] review denied: [Bug 47715] Web Inspector: move frontend settings to local storage : [Attachment 71564] Use shorter keys (no "application" prefix).

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 47715: Web Inspector: move frontend settings to local storage
https://bugs.webkit.org/show_bug.cgi?id=47715

Attachment 71564: Use shorter keys (no "application" prefix).
https://bugs.webkit.org/attachment.cgi?id=71564&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71564&action=review

> WebCore/inspector/front-end/Panel.js:37
> +   
WebInspector.applicationSettings.installSetting(this._sidebarWidthSettingName()
, "application", undefined);

It should be

WebInspector.settings.installApplicationSetting and
WebInspector.settings.installProjectSetting

> WebCore/inspector/front-end/Settings.js:97
> +	       return key + "." + this._mainResourceURL;

You might want to ignore fragment here.