[webkit-reviews] review granted: [Bug 48053] Make http locking default in NRWT : [Attachment 71535] proposed_patch_v2

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 48053: Make http locking default in NRWT
https://bugs.webkit.org/show_bug.cgi?id=48053

Attachment 71535: proposed_patch_v2
https://bugs.webkit.org/attachment.cgi?id=71535&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Code looks fine. I think it would be clearer if there were just two methods:
_start_servers_with_lock and _stop_servers_with_lock and those two methods
contained all the logic. So, I would merge _stop_http_lock into
_stop_servers_with_lock and the logic of lines 401-404 into
_start_servers_with_lock. Then the if statement would look like this:

if self._current_group == "tests_to_http_lock":
    self._start_servers_with_lock()
elif self._have_http_lock:
    self._stop_servers_with_lock()