[webkit-reviews] review granted: [Bug 47339] Web Inspector: Implement property toggling in InspectorCSSAgent : [Attachment 71560] [PATCH] The right fix for the comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 22 07:20:36 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 47339: Web Inspector: Implement property toggling in InspectorCSSAgent
https://bugs.webkit.org/show_bug.cgi?id=47339

Attachment 71560: [PATCH] The right fix for the comments
https://bugs.webkit.org/attachment.cgi?id=71560&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This now looks good. See single comment below. I'd suggest that we land it
after this review and do a follow-up inspection in the source. The change has
been up in the air for too long and it is fairly large.

> WebCore/inspector/InspectorStyleSheet.h:52
> +class InspectorCompoundId {

How about we rename it to InspectorStyleId and hardcode the style id structure?
(I.e. stylesheet id and style id parts).


More information about the webkit-reviews mailing list