[webkit-reviews] review requested: [Bug 48125] Further preparations to deploy the new SVGAnimatedProperty concept for the rest of the SVG datatypes : [Attachment 71557] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 22 06:13:17 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 48125: Further preparations to deploy the new SVGAnimatedProperty concept
for the rest of the SVG datatypes
https://bugs.webkit.org/show_bug.cgi?id=48125

Attachment 71557: Patch v2
https://bugs.webkit.org/attachment.cgi?id=71557&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Ouch, forgot the destructor. SVGPropertyTearOff does it right,
SVGListPropertyTearOff also needs to delete m_values if m_valuesIsCopy=true.
The code is yet unused, when I convert SVGStringList to use this new code, I
would have noticed it on a leaks run...


More information about the webkit-reviews mailing list