[webkit-reviews] review granted: [Bug 48121] Web Inspector: update resources tree in storage panel upon network events. : [Attachment 71546] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 48121: Web Inspector: update resources tree in storage panel upon network
events.
https://bugs.webkit.org/show_bug.cgi?id=48121

Attachment 71546: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=71546&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71546&action=review

> WebCore/inspector/InspectorResourceAgent.cpp:354
> +    frameObject->setNumber("parentId",
reinterpret_cast<uintptr_t>(frame->tree()->parent()));

can we extract this reinterpret_cast into a function that would convert to the
id for us?

> WebCore/inspector/front-end/StoragePanel.js:187
> +		       (child._resource.type !==
WebInspector.Resource.Type.Document &&
child._resource.displayName.localeCompare(resource.displayName) > 0)) {

style: wrong alignment