[webkit-reviews] review denied: [Bug 48120] SVGColor::cssText() shouldn't return #RRGGBBAA colors : [Attachment 71545] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 48120: SVGColor::cssText() shouldn't return #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=48120

Attachment 71545: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=71545&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71545&action=review

Fix looks good, but tests do not.

> LayoutTests/ChangeLog:9
> +	   Color::serialized() is already exercised in depth by fast/canvas
tests.

Sure, it’s good that function has good test coverage, but this patch doesn’t
include a test case for the bug you are fixing!

These test results only show that we are switching from uppercase hex to
lowercase hex.