[webkit-reviews] review denied: [Bug 45712] Add selectionchange event : [Attachment 71367] added onselectionchange to HTMLAttributesNames.idl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 22 00:17:13 PDT 2010


Kent Tamura <tkent at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 45712: Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712

Attachment 71367: added onselectionchange to HTMLAttributesNames.idl
https://bugs.webkit.org/attachment.cgi?id=71367&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
I agree with ap.
For example, HTMLInputElement::setValue() updates selection only if the element
has focus, and access a data member. If we apply this patch,
HTMLInputElement::setValue() will have new crash.
We need to check all of code paths to SelectionController::setSelection() if
'selectionchange' event is synchronous.


More information about the webkit-reviews mailing list