[webkit-reviews] review granted: [Bug 46676] HTMLTreeBuilder's InForeignContent code needs a re-write : [Attachment 71523] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 46676: HTMLTreeBuilder's InForeignContent code needs a re-write
https://bugs.webkit.org/show_bug.cgi?id=46676

Attachment 71523: Patch
https://bugs.webkit.org/attachment.cgi?id=71523&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71523&action=review

Quite nice.  Thanks!

> WebCore/html/parser/HTMLTreeBuilder.cpp:2616
> +	   setInsertionMode(InBodyMode);
>	   processEndOfFile(token);

No prepareToReprocess here?

> WebCore/html/parser/HTMLTreeBuilder.cpp:2629
> +	   prepareToReprocessToken();
>	   processEndOfFile(token);

We could have added a reprocessEndOfFile call for symmetry, but I can see why
you skipped it.