[webkit-reviews] review denied: [Bug 46927] Sunspider 0.9 web site should prominently link to Sunspider 0.9.1 : [Attachment 71518] Update the Sunspider 0.9 html page to point to the new version: 0.9.1. Also added a "previous versions" list such that 0.9 is still available.

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 46927: Sunspider 0.9 web site should prominently link to Sunspider 0.9.1
https://bugs.webkit.org/show_bug.cgi?id=46927

Attachment 71518: Update the Sunspider 0.9 html page to point to the new
version: 0.9.1.  Also added a "previous versions" list such that 0.9 is still
available.
https://bugs.webkit.org/attachment.cgi?id=71518&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I don't think this is a great solution to this bug.

The fundamental problem here is that we've never put up a version agnostic
front page for SunSpider – instead we have a version specific one.  Having
'sunspider-0.9/sunspider.html' optionally launch version 0.9.1 isn't
particularly clean, and if we leave this as the main page for the benchmark
then we continue to propagate a mess into the future – we'll end up with
multiple front pages for the benchmark ('sunspider-0.9/sunspider.html',
'sunspider-0.9.1/sunspider.html', etc), all of which can launch multiple
variants of the benchmark.

I'd suggest that a much better solution would be to try to establish a
version-agnostic front page for SunSpider.  We should move SunSpider's home to
something like 'webkit.org/perf/sunspider/sunspider.html', and make the
existing 'sunspider.html's in the sunspider-0.9 & sunspider-0.9.1 directories
redirect here.	This would keep existing links working, while giving people a
better location to link to & bookmark going forwards.  This new page could have
a button to directly launch current version the current version, and a link to
the versions page, that lists all versions.

The versions page should also move.  It is currently found at
'webkit.org/perf/sunspider-0.9.1/versions.html', however this is clearly
nonsensical.  It would not make sense for the list of all versions to itself be
version-specific.  'versions.html' should move to
'webkit.org/perf/sunspider/versions.html' (alongside the proposed new
version-agnostic home for the 'sunspider.html' homepage).

(Or alternatively to the last couple of comments, the versions page could be
removed, and links to older versions could be included directly on the front
page – either way could make sense.)