[webkit-reviews] review denied: [Bug 47885] [Win][DRT] should have LayoutTestController.hasSpellingMarker() : [Attachment 71242] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 47885: [Win][DRT] should have LayoutTestController.hasSpellingMarker()
https://bugs.webkit.org/show_bug.cgi?id=47885

Attachment 71242: Patch
https://bugs.webkit.org/attachment.cgi?id=71242&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71242&action=review

> WebKitTools/DumpRenderTree/win/EditingDelegate.cpp:357
> +static int indexOfFirstAlphabet(const TCHAR* text)

The function names should be indexOfFirstWordCharacter because misspelled words
might contain digits in the future.
We don't need to change the implementation for now.

> WebKitTools/DumpRenderTree/win/EditingDelegate.cpp:365
> +static int indexOfFirstNonAlphabet(const TCHAR* text)

ditto. This should be indexOfFirstNonWordCharacter, or lengthOfWord as
Niwa-san's suggestion.