[webkit-reviews] review requested: [Bug 25321] RLE/LRE characters are removed from any text entered into a text box (either using a keyboard or by pasting) : [Attachment 71517] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 18:21:12 PDT 2010


Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 25321: RLE/LRE characters are removed from any text entered into a text box
(either using a keyboard or by pasting)
https://bugs.webkit.org/show_bug.cgi?id=25321

Attachment 71517: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=71517&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
2 questions on ATSUI:

1. inside ComplexTextController::ComplexTextRun::ComplexTextRun() in
ComplexTextControllerATSUI.cpp,
there is the following line:
    status = ATSUGetGlyphBounds(atsuTextLayout, 0, 0, 0, m_stringLength,
kATSUseFractionalOrigins, 0, 0, &boundsCount);

Since there is ATSUTextInserted() and newly added ATSUTextDeleted(), should it
be:
    status = ATSUGetGlyphBounds(atsuTextLayout, 0, 0, 0, kATSUToTextEnd,
kATSUseFractionalOrigins, 0, 0, &boundsCount); ?


2. I am running on snow leopard, how do I test ATSUI?


More information about the webkit-reviews mailing list