[webkit-reviews] review requested: [Bug 47560] Ignore document.write() when it comes from a network task : [Attachment 71508] Fix src removal bug

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has asked	for review:
Bug 47560: Ignore document.write() when it comes from a network task
https://bugs.webkit.org/show_bug.cgi?id=47560

Attachment 71508: Fix src removal bug
https://bugs.webkit.org/attachment.cgi?id=71508&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
> Why can't an inline script have a sourceAttributeValue ?  I guess that would
cause the script to be external.

>From the spec: "For the purposes of these steps, the script is considered to be
from an external file if, while the running a script algorithm above was
running for this script, the script element had a src attribute specified."

> What happens if we have a defer script that kicks off a load and then an
inline script later comes and removes the src attribute (before the script
executes)?  Will the script no longer be write disabled?

Good catch! The spec does say "had a src attribute" not "has." I fixed that up
and added a test case that failed previously.