[webkit-reviews] review granted: [Bug 43017] removeFormat needs to be reimplemented : [Attachment 71505] fixed per Tony's comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 16:21:10 PDT 2010


Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 43017: removeFormat needs to be reimplemented
https://bugs.webkit.org/show_bug.cgi?id=43017

Attachment 71505: fixed per Tony's comment
https://bugs.webkit.org/attachment.cgi?id=71505&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71505&action=review

> WebCore/editing/ApplyStyleCommand.cpp:1536
> +    Vector<RefPtr<Element> > elementsToPushDown;

Nit: Maybe add a comment explaining why you need this vector.  I don't think
it's obvious from the code.


More information about the webkit-reviews mailing list