[webkit-reviews] review granted: [Bug 48092] Crash evaluating JavaScript string that throws an exception : [Attachment 71495] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 48092: Crash evaluating JavaScript string that throws an exception
https://bugs.webkit.org/show_bug.cgi?id=48092

Attachment 71495: Patch
https://bugs.webkit.org/attachment.cgi?id=71495&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71495&action=review

> WebKitTools/ChangeLog:15
> +	   (TestWebKitAPI::TEST):

I've been replacing this line with TestWebKitAPI::WebKit2_EvaluateJavaScript
(e.g.).

> WebKitTools/TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:42
> +    // FIXME: We should also check the error, but right now it's always
null.

Maybe you should TEST_ASSERT that it is null. Then we will have something
reminding us we need to update this test when we make it be non-null!