[webkit-reviews] review granted: [Bug 48091] Web Inspector: stub out WebInspectorFrontendClient for WebKit2 : [Attachment 71491] Proposed Change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 14:25:14 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 48091: Web Inspector: stub out WebInspectorFrontendClient for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48091

Attachment 71491: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=71491&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71491&action=review

> WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:47
> +void WebInspectorFrontendClient::moveWindowBy(float x, float y)

You can remove these parameter names.

I wonder why this doesn't take a const FloatSize&?


More information about the webkit-reviews mailing list