[webkit-reviews] review denied: [Bug 48088] Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch : [Attachment 71488] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 14:07:55 PDT 2010


Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 48088: Add --suggest-reviewers option to upload to auto-suggest reviewers
for your patch
https://bugs.webkit.org/show_bug.cgi?id=48088

Attachment 71488: Patch
https://bugs.webkit.org/attachment.cgi?id=71488&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71488&action=review

Also, it should work for post!

> WebKitTools/Scripts/webkitpy/tool/steps/suggestreviewers.py:45
> +	   reviewers =
self._tool.checkout().suggested_reviewers(self._options.git_commit)

You're not passing in the set of changed_files.

> WebKitTools/Scripts/webkitpy/tool/steps/suggestreviewers.py:50
> +	   reviewer_emails = [reviewer.bugzilla_email() for reviewer in
reviewers]

You can use map for this if you like.


More information about the webkit-reviews mailing list