[webkit-reviews] review granted: [Bug 47767] [Qt] All widgets are rendered incorrectly when rendered through a cache : [Attachment 71437] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 47767: [Qt] All widgets are rendered incorrectly when rendered through a
cache
https://bugs.webkit.org/show_bug.cgi?id=47767

Attachment 71437: Patch
https://bugs.webkit.org/attachment.cgi?id=71437&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71437&action=review

> WebCore/platform/qt/RenderThemeQt.cpp:92
> +    if (widget)
> +	   option.initFrom(widget);
> +    else
> +	   /*
> +	     If a widget is not directly available for rendering, we fallback
to default
> +	     value for an active widget.
> +	    */
> +	   option.state = QStyle::State_Active | QStyle::State_Enabled;

>From the style guide: "One-line control clauses should not use braces unless
comments are included or a single statement spans multiple lines." So curly
braces are needed here.

The rest of the patch looks great! r+, but please this style buglet before
landing :)