[webkit-reviews] review denied: [Bug 33903] FTBFS on GNU/kFreeBSD caused by missing strnstr() on glibc systems : [Attachment 71477] Patch to use HAVE_STRNSTRN

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 12:57:14 PDT 2010


Darin Adler <darin at apple.com> has denied Anton Faern <bladehawke at gmail.com>'s
request for review:
Bug 33903: FTBFS on GNU/kFreeBSD caused by missing strnstr() on glibc systems
https://bugs.webkit.org/show_bug.cgi?id=33903

Attachment 71477: Patch to use HAVE_STRNSTRN
https://bugs.webkit.org/attachment.cgi?id=71477&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This patch will break non-configure-based platforms that have strnstr, which is
the majority of platforms we support. Platform.h needs to set HAVE_STRNSTR for
those platforms.


More information about the webkit-reviews mailing list