[webkit-reviews] review granted: [Bug 48085] Make basic vertical text painting work. : [Attachment 71469] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 48085: Make basic vertical text painting work.
https://bugs.webkit.org/show_bug.cgi?id=48085

Attachment 71469: Patch
https://bugs.webkit.org/attachment.cgi?id=71469&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71469&action=review

> WebCore/WebCore.xcodeproj/project.pbxproj:-21155
> -			developmentRegion = English;

You need to update your Xcode with Software Update. The newer version doesn’t
remove this, and you should not check in this project change.

> WebCore/rendering/InlineFlowBox.cpp:-708
> -	       paintTextDecorations(paintInfo, tx, ty, false);

How does this work now? Is there other code that always paints text decorations
now that used to do it only conditionally?

> WebCore/rendering/InlineTextBox.cpp:433
> +	   context->rotate(deg2rad(90.));

We normally would just use 90 here instead of "90." but maybe that will cause
overloading problems with the deg2rad function. Also, this will call deg2rad at
runtime -- maybe we should include a constant you can use for this. Maybe a
helper function to rotate 90 degrees would be cleaner?