[webkit-reviews] review granted: [Bug 48048] [GTK] WebKitWebFrame's load-status is not properly notified to the tests : [Attachment 71415] New provisional-load-fail status signal.

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 48048: [GTK] WebKitWebFrame's load-status is not properly notified to the
tests
https://bugs.webkit.org/show_bug.cgi?id=48048

Attachment 71415: New provisional-load-fail status signal.
https://bugs.webkit.org/attachment.cgi?id=71415&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71415&action=review

Looks good, though we need another nod from a GTK+ review for the API change.

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:596
> +

I think the extra line can be removed.

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1136
> +    notifyStatus(m_frame, WEBKIT_LOAD_PROVISIONAL_FAILED);
> +

Same here.

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1146
> +    if (m_loadingErrorPage)
> +	   return;
> +
> +    notifyStatus(m_frame, WEBKIT_LOAD_FAILED);
> +

And here.