[webkit-reviews] review denied: [Bug 48053] Make http locking default in NRWT : [Attachment 71413] proposed patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 48053: Make http locking default in NRWT
https://bugs.webkit.org/show_bug.cgi?id=48053

Attachment 71413: proposed patch
https://bugs.webkit.org/attachment.cgi?id=71413&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71413&action=review

Should we remove start/stop server calls from run_webkit_tests.py as well?
Seems like we should only need to do this in dump_render_tree_thread, right?

> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:587
> +    def start_servers_to_lock(self):
> +	   self.start_http_server()
> +	   self.start_websocket_server()
> +
> +    def stop_servers_to_lock(self):
> +	   self.stop_http_server()
> +	   self.stop_websocket_server()

Can we move the acquire_http_lock and release_http_lock calls into these
functions? And maybe rename them to
start_servers_with_lock/stop_servers_with_lock?