[webkit-reviews] review requested: [Bug 30123] [GTK] Segfault while testing accessibility/iframe-bastardization.html : [Attachment 71443] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 30123: [GTK] Segfault while testing
accessibility/iframe-bastardization.html
https://bugs.webkit.org/show_bug.cgi?id=30123

Attachment 71443: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=71443&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
The attached patch fixed the crash by properly checking that m_element is not a
null value before actually using it. Current code was failing because the
ASSERT(m_element) statement will not work out of debug builds, so it's needed
(as it's done in other functions in the same file) to add that extra check. On
top of that, now that it's 100% sure m_element is not a null value if it passes
that check, we can ASSERT(ATK_IS_OBJECT(m_element)) instead of just doing
ASSERT(m_element)

Please notice that this patch just fixes the crash (which is what this bug is
about), but it doesn't fix anything else so the Layout test can't be removed
yet from the Skipped file. That would be another bug, IMHO.

Asking for review.