[webkit-reviews] review granted: [Bug 45482] 'transparent' should be a valid color : [Attachment 71438] Rework test to use SVG animation testing shizzle

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 45482: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482

Attachment 71438: Rework test to use SVG animation testing shizzle
https://bugs.webkit.org/attachment.cgi?id=71438&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71438&action=review

Much better! Please fix some issues before landing:

> LayoutTests/svg/animations/script-tests/animate-color-transparent.js:6
> +rect.setAttribute("id", "test");

This is not needed.

> LayoutTests/svg/animations/script-tests/animate-color-transparent.js:12
> +animate.setAttribute("id", "animation");

Ditto.

> LayoutTests/svg/animations/script-tests/animate-color-transparent.js:44
> +window.setTimeout("triggerUpdate(15, 30)", 0);

Maybe use 50, 50 here, to indicate the middle of the rect, looks less obscure.