[webkit-reviews] review denied: [Bug 15713] Outside list bullets ignore text-align style : [Attachment 71420] Fix the position of outside list bullets
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 21 04:53:56 PDT 2010
Andreas Kling <kling at webkit.org> has denied Renata Hodovan
<reni at inf.u-szeged.hu>'s request for review:
Bug 15713: Outside list bullets ignore text-align style
https://bugs.webkit.org/show_bug.cgi?id=15713
Attachment 71420: Fix the position of outside list bullets
https://bugs.webkit.org/attachment.cgi?id=71420&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71420&action=review
> WebCore/ChangeLog:8
> + Fix the outside markers position with saving the start position of
the current line and adding this value to the markers postion.
s/markers/marker's/g
s/with/by/
> WebCore/rendering/RenderListMarker.h:48
> + const int outsideMarkerOffset() const
Unnecessary const, should be "int outsideMarkerOffset() const"
> LayoutTests/ChangeLog:5
> + Need a short description and bug URL (OOPS!)
Oops, indeed!
> LayoutTests/fast/lists/outSideListMarkers.html:20
> +<p><u>text-align: rigth</u></p>
s/rigth/right/
More information about the webkit-reviews
mailing list