[webkit-reviews] review granted: [Bug 48058] Web Inspector: decouple ScriptArguments from ScriptCallStack : [Attachment 71419] Manually uploaded patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 48058: Web Inspector: decouple ScriptArguments from ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=48058

Attachment 71419: Manually uploaded patch
https://bugs.webkit.org/attachment.cgi?id=71419&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71419&action=review

> WebCore/bindings/scripts/CodeGeneratorJS.pm:1970
> +			   push(@implContent, "    size_t maxStackSize =
imp->shouldCaptureFullStackTrace() ? ScriptCallStack::maxCallStackSizeToCapture
: 1;\n");

Nit: I'd use the opposite one "shouldCaptureTopFrameOnly()"