[webkit-reviews] review granted: [Bug 39625] [Qt] Sending a QInputMethodEvent::Selection event forces the Editor to go into Composition mode : [Attachment 70976] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 03:46:30 PDT 2010


Simon Hausmann <hausmann at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 39625: [Qt] Sending a QInputMethodEvent::Selection event forces the Editor
to go into Composition mode
https://bugs.webkit.org/show_bug.cgi?id=39625

Attachment 70976: Patch
https://bugs.webkit.org/attachment.cgi?id=70976&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70976&action=review

> WebKit/qt/Api/qwebpage.cpp:-1051
> -	       selection = a;

I think you can also remove the function-local selection variable altogether
with your change.


More information about the webkit-reviews mailing list