[webkit-reviews] review granted: [Bug 47990] [GTK] Replace encodings multi-dimensional array with calls to registrar method : [Attachment 71400] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 00:57:36 PDT 2010


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 47990: [GTK] Replace encodings multi-dimensional array with calls to
registrar method
https://bugs.webkit.org/show_bug.cgi?id=47990

Attachment 71400: Updated patch
https://bugs.webkit.org/attachment.cgi?id=71400&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71400&action=review

Great! Thank you.

> WebCore/platform/text/gtk/TextCodecGtk.cpp:62
> +static bool isEncodingAvailable(const gchar* encName)

encName should be replaced with encodingName, since we are avoiding
abbreviations in new code. I'll fix this and land it myself. :)


More information about the webkit-reviews mailing list