[webkit-reviews] review denied: [Bug 47681] [Chromium] implementation of async FileWriter for workers : [Attachment 71378] Rolled in Michael's comments, including the KURL change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 19:59:10 PDT 2010


David Levin <levin at chromium.org> has denied Eric U. <ericu at chromium.org>'s
request for review:
Bug 47681: [Chromium] implementation of async FileWriter for workers
https://bugs.webkit.org/show_bug.cgi?id=47681

Attachment 71378: Rolled in Michael's comments, including the KURL change.
https://bugs.webkit.org/attachment.cgi?id=71378&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'm not sure why this is up for review. The strings are still in the
ThreadSafeShared class.

I could point out nits but that code may change.

I could try to understand the structure and point out issues there but it is
hard for me to know what is going to change (due to those strings).

btw, I'd recommend make the fileInfo change as a separate patch. It looks
independent and something that could get r+'ed quickly.

r- due to the strings in the ThreadSafeShared class (and not wanting to spend
time diving into code that may change a fair bit due to this).


More information about the webkit-reviews mailing list