[webkit-reviews] review denied: [Bug 47936] Renumber FileError/FileException error codes per latest File API spec changes : [Attachment 71336] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 47936: Renumber FileError/FileException error codes per latest File API
spec changes
https://bugs.webkit.org/show_bug.cgi?id=47936

Attachment 71336: Patch
https://bugs.webkit.org/attachment.cgi?id=71336&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71336&action=review

> LayoutTests/ChangeLog:11
> +	   * fast/files/read-file-async-expected.txt:

You'd better also update fast/files/workers/read-*-async-expected.txt though
worker tests are skipped now.

> WebCore/dom/ExceptionCode.cpp:197
> +    "A requested file or directory could not be found at the time an
operation was processed.",

Where did you get the message?

> WebCore/fileapi/FileError.h:43
> +    enum FileErrorCode {

Probably it is simpler to name it as ErrorCode as in PositionError.h or
GeolocationError.h.

> WebCore/fileapi/FileException.h:65
> +    static int FileErrorCodeToExceptionCode(int fileErrorCode)

Probably simpler to call it as ErrorCodeToExceptionCode.