[webkit-reviews] review granted: [Bug 48028] Adding MediaQueryListListener binding test cases : [Attachment 71370] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 17:40:49 PDT 2010


Darin Adler <darin at apple.com> has granted Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 48028: Adding MediaQueryListListener binding test cases
https://bugs.webkit.org/show_bug.cgi?id=48028

Attachment 71370: patch
https://bugs.webkit.org/attachment.cgi?id=71370&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71370&action=review

Assuming you generated these files with run-bindings-tests, r=me.

> WebCore/ChangeLog:18
> +	  
(WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListenerPrivate::Web
DOMTestMediaQueryListListenerPrivate):
> +	  
(WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListener):
> +	   (WebDOMTestMediaQueryListListener::operator=):
> +	   (WebDOMTestMediaQueryListListener::impl):
> +	  
(WebDOMTestMediaQueryListListener::~WebDOMTestMediaQueryListListener):
> +	   (WebDOMTestMediaQueryListListener::method):
> +	   (toWebCore):
> +	   (toWebKit):

You can leave out these lists of functions in added files.


More information about the webkit-reviews mailing list