[webkit-reviews] review denied: [Bug 41497] GraphicsLayer: z-index causes a repaint of a layer : [Attachment 70169] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 41497: GraphicsLayer: z-index causes a repaint of a layer
https://bugs.webkit.org/show_bug.cgi?id=41497

Attachment 70169: Patch
https://bugs.webkit.org/attachment.cgi?id=70169&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70169&action=review

> WebCore/rendering/style/RenderStyle.cpp:510
> +	   } else if (m_box->zIndex() != other->m_box->zIndex() ||
m_box->hasAutoZIndex() != other->m_box->hasAutoZIndex()
> +		    || visual->clip != other->visual->clip || visual->hasClip
!= other->visual->hasClip)
> +#if USE(ACCELERATED_COMPOSITING)
> +	       changedContextSensitiveProperties |=
ContextSensitivePropertyZIndex;

You're setting ContextSensitivePropertyZIndex when the clip changes, which is
wrong.