[webkit-reviews] review denied: [Bug 45640] Navigating dark background websites results in blinding white flashes between pages. : [Attachment 70587] Patch

Wed Oct 20 14:57:49 PDT 2010

Dave Hyatt <hyatt at apple.com> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 45640: Navigating dark background websites results in blinding white
flashes between pages.
https://bugs.webkit.org/show_bug.cgi?id=45640

Attachment 70587: Patch
https://bugs.webkit.org/attachment.cgi?id=70587&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70587&action=review

> WebCore/dom/Document.cpp:4770
> +    if (document()->didLayoutWithPendingStylesheets())

Don't need document()-> here.

> WebCore/dom/Document.cpp:4772
> +    // Many websites give thier background style using <body> instead of
<html>.

Typo. "thier" should be "their"

> WebCore/dom/Document.cpp:4776
> +    if ((isHTMLDocument() || isXHTMLDocument()) && !body())
> +	   return true;
> +    return false;

Can just write this as:

return (isHTMLDocument() || isXHtmlDocument()) && !body();

I'd also flip the check.  It's cheaper to ask if body() is present then to make
the virtual function call to ask what kind of document you are.

> WebCore/page/FrameView.cpp:306
> +	   if (hostWindow() && shouldUpdate(false))

Don't need "false" here.  It's the default value.