[webkit-reviews] review denied: [Bug 47174] Moving all bounding box related calculation to RenderSVGResourceFilterPrimitive : [Attachment 71283] patch 2

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 47174: Moving all bounding box related calculation to
RenderSVGResourceFilterPrimitive
https://bugs.webkit.org/show_bug.cgi?id=47174

Attachment 71283: patch 2
https://bugs.webkit.org/attachment.cgi?id=71283&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71283&action=review

Just style issues remaining. Great Patch! Looking forward to see a fixed
version of this patch and a followup with turning
determineFilterPrimitiveSubregion into a member of the Renderer. r- for now.

> WebCore/platform/graphics/filters/ImageBufferFilter.h:-46
> -    virtual FloatSize maxImageSize() const { return FloatSize(); }

This file doesn't exist any longer. Revert this file in your local copy and
update to trunk. Shouldn't cause any problems.

> WebCore/rendering/RenderSVGResourceFilterPrimitive.cpp:39
> +    FloatRect subRegionBoundingBox = effect->effectBoundaries();
> +    FloatRect newSubRegion = subRegionBoundingBox;

We use just subregion, not subRegion now.

> WebCore/rendering/RenderSVGResourceFilterPrimitive.cpp:49
> +    }
> +    else {

} else {

> WebCore/rendering/RenderSVGResourceFilterPrimitive.h:46
> +    // These two arguments are depend on the RenderObject

s/depend/dependent/ or just they depend on...

> WebCore/svg/graphics/filters/SVGFilter.cpp:@
>  SVGFilter::SVGFilter(const AffineTransform& absoluteTransform, const
FloatRect&

Remove the SVGFEImage.h include in this file.