[webkit-reviews] review denied: [Bug 47959] Add support for --tolerance in NRWT : [Attachment 71234] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 47959: Add support for --tolerance in NRWT
https://bugs.webkit.org/show_bug.cgi?id=47959

Attachment 71234: Patch
https://bugs.webkit.org/attachment.cgi?id=71234&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71234&action=review

Is there anyway to test this? Not that the tolerance actually does the right
thing, just a test that the code doesn't crash when you pass a tolerance would
be enough for me.

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:1567
> +		   "ports may ignore this option)", type="float", default=0.1),


I'd prefer if we default to 0 and then allow individual ports to override the
tolerance somehow. As it is, each port currently has a different default.