[webkit-reviews] review granted: [Bug 43462] Complex MathML test takes over 20s to render : [Attachment 71125] Updated patch with latest optimizations for layout

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Alex Milowski
<alex at milowski.com>'s request for review:
Bug 43462: Complex MathML test takes over 20s to render
https://bugs.webkit.org/show_bug.cgi?id=43462

Attachment 71125: Updated patch with latest optimizations for layout
https://bugs.webkit.org/attachment.cgi?id=71125&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71125&action=review

Generally looks good. It actually seems to simplify the code. I notice that in
simple fractions, the denominator almost touches the line. I do not know if
this is a regression, but maybe this be improved?

> WebCore/mathml/RenderMathMLRow.cpp:79
> +	       // Check to see if the non-operator block has a greater height

Please add a dot at the end of comments, that is out webkit style