[webkit-reviews] review denied: [Bug 47984] Web Inspector: lastActivePanel things were refactored. : [Attachment 71287] [patch] initial version.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 20 07:12:10 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied review:
Bug 47984: Web Inspector: lastActivePanel things were refactored.
https://bugs.webkit.org/show_bug.cgi?id=47984
Attachment 71287: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=71287&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71287&action=review
> WebCore/inspector/InspectorController.cpp:277
> + m_state->setString(InspectorState::showPanel, ElementsPanel);
1. This is not inspector's state
2. You should not mirror it to the front-end
More information about the webkit-reviews
mailing list