[webkit-reviews] review granted: [Bug 47922] Merge ColorSpace and ImageColorSpace enums : [Attachment 71274] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 06:04:38 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 47922: Merge ColorSpace and ImageColorSpace enums
https://bugs.webkit.org/show_bug.cgi?id=47922

Attachment 71274: Patch
https://bugs.webkit.org/attachment.cgi?id=71274&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks great, r=me.
Please do a leaks run first, as I'm not 100% certain about the removal of
RetainPtr for m_colorSpace. Looks fine according to the CoreGraphics docs
though, but better be safe than sorry.


More information about the webkit-reviews mailing list