[webkit-reviews] review denied: [Bug 47968] Web Inspector: Handle WebSocket events via InspectorInstrumentation : [Attachment 71256] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied  review:
Bug 47968: Web Inspector: Handle WebSocket events via InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=47968

Attachment 71256: Patch
https://bugs.webkit.org/attachment.cgi?id=71256&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71256&action=review

> WebCore/websockets/WebSocketChannel.cpp:39
>  #include "InspectorController.h"

Please remove this import, InspectorInstrumentation should be enough.

> WebCore/websockets/WebSocketChannel.cpp:75
> +    InspectorInstrumentation::didCreateWebSocket(m_context, identifier(),
url, m_context->url());

Now that you removed #if ENABLE(INSPECTOR) guard, identifier() will be called
even when inspector is disabled, but the method is behind the guard:

	#if ENABLE(INSPECTOR)
	unsigned long WebSocketChannel::identifier()

r- for this.